linux-kernel - Re: kernel/module: Delete an error message for a failed memory allocation in add_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 12:42:12 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Jessica Yu <jeyu@...nel.org>, kernel-janitors@...r.kernel.org
Cc:     Rusty Russell <rusty@...tcorp.com.au>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: kernel/module: Delete an error message for a failed memory
 allocation in add_module_usage()

>> @@ -837,10 +837,8 @@ static int add_module_usage(struct module *a, struct module *b)
>>
>>     pr_debug("Allocating new usage for %s.\n", a->name);
>>     use = kmalloc(sizeof(*use), GFP_ATOMIC);
>> -    if (!use) {
>> -        pr_warn("%s: out of memory loading\n", a->name);
>> +    if (!use)
>>         return -ENOMEM;
>> -    }
> 
> IMO this is removing useful information.

How do you think about to clarify the circumstances any further?


> Although stack traces are generated on alloc failures,

Do you ever want to switch them off for special use cases?


> the extra print also tells us which module we were trying to load
> at the time the memory allocation failed.

Can a default allocation failure report provide the same information already?

Regards,
Markus