linux-kernel - Re: kernel/module: Delete an error message for a failed memory allocation in add_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1508412567.6806.36.camel@perches.com>
Date:   Thu, 19 Oct 2017 04:29:27 -0700
From:   Joe Perches <joe@...ches.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Jessica Yu <jeyu@...nel.org>
Cc:     kernel-janitors@...r.kernel.org,
        Rusty Russell <rusty@...tcorp.com.au>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: kernel/module: Delete an error message for a failed memory
 allocation in add_module_usage()

On Thu, 2017-10-19 at 13:18 +0200, SF Markus Elfring wrote:
> > > Omit an extra message for a memory allocation failure in this function.
> > > 
> > > This issue was detected by using the Coccinelle software.
> > > 
> > > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> > 
> > Applied to modules-next, thanks.
> 
> Thanks for your acceptance of this update suggestion after a bit of clarification.
> 
> Do you see any need that I should extend subsequent commit messages
> for this software transformation pattern?

Add a description of _why_ this is being done.

Something like:

"because there is a dump_stack() done on allocation failures
 without __GFP_JNOWARN"