linux-kernel - Re: char/tpm: Improve a size determination in nine functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019140406.046d2714@kitsune.suse.cz>
Date:   Thu, 19 Oct 2017 14:04:06 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-integrity@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>,
        Nayna Jain <nayna@...ux.vnet.ibm.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jerry Snitselaar <jsnitsel@...hat.com>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Julia Lawall <julia.lawall@...6.fr>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        Kenneth Goldman <kgold@...ux.vnet.ibm.com>,
        Paul Mackerras <paulus@...ba.org>,
        Peter Hüwe <PeterHuewe@....de>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>
Subject: Re: char/tpm: Improve a size determination in nine functions

On Wed, 18 Oct 2017 21:03:13 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Wed, 2017-10-18 at 19:48 +0200, SF Markus Elfring wrote:
> > > For 1/4 and 2/4: explain why the message can be omitted.  
> 
> > > That's all.  
> > 
> > I assume that there might be also some communication challenges
> > involved.
> > 
> >   
> > > 3/4: definitive NAK, too much noise compared to value.  
> > 
> > I tried to reduce deviations from the Linux coding style again.
> > You do not like such an attempt for this software area so far.  
> 
> The problem here in a time line or what comes first. Definitely, you
> are trying to fix the code which _is_ upstream vs. the code which
> _might be_ upstream (exception is drivers/staging).
> 
> Why didn't you listen to what people are telling you?
> 
> Why are you spending too much time on little sense crap instead of
> doing real fixes?
> 

People are free to spend their time on what they like.

Even if no commit of this series lands in mainline it has been useful
to clarify what is preferred style and what is useful fix.

Thanks

Michal