lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Oct 2017 15:48:22 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Darius Ivanauskas <dasilt@...oo.com>, Matt Redfearn <matt.redfearn@...tec.com>, Chris Metcalf <cmetcalf@...lanox.com>, Petr Mladek <pmladek@...e.com>, Aaron Tomlin <atomlin@...hat.com>, "Jason A. Donenfeld" <jason@...c4.com>, linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org> Subject: [PATCH 4.9 01/51] MIPS: Fix minimum alignment requirement of IRQ stack 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matt Redfearn <matt.redfearn@...tec.com> commit 5fdc66e046206306bf61ff2d626bfa52ca087f7b upstream. Commit db8466c581cc ("MIPS: IRQ Stack: Unwind IRQ stack onto task stack") erroneously set the initial stack pointer of the IRQ stack to a value with a 4 byte alignment. The MIPS32 ABI requires that the minimum stack alignment is 8 byte, and the MIPS64 ABIs(n32/n64) require 16 byte minimum alignment. Fix IRQ_STACK_START such that it leaves space for the dummy stack frame (containing interrupted task kernel stack pointer) while also meeting minimum alignment requirements. Fixes: db8466c581cc ("MIPS: IRQ Stack: Unwind IRQ stack onto task stack") Reported-by: Darius Ivanauskas <dasilt@...oo.com> Signed-off-by: Matt Redfearn <matt.redfearn@...tec.com> Cc: Chris Metcalf <cmetcalf@...lanox.com> Cc: Petr Mladek <pmladek@...e.com> Cc: Aaron Tomlin <atomlin@...hat.com> Cc: Jason A. Donenfeld <jason@...c4.com> Cc: linux-mips@...ux-mips.org Cc: linux-kernel@...r.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/16760/ Signed-off-by: Ralf Baechle <ralf@...ux-mips.org> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- arch/mips/include/asm/irq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/mips/include/asm/irq.h +++ b/arch/mips/include/asm/irq.h @@ -18,7 +18,7 @@ #include <irq.h> #define IRQ_STACK_SIZE THREAD_SIZE -#define IRQ_STACK_START (IRQ_STACK_SIZE - sizeof(unsigned long)) +#define IRQ_STACK_START (IRQ_STACK_SIZE - 16) extern void *irq_stack[NR_CPUS];
Powered by blists - more mailing lists