lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Oct 2017 15:48:23 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Ben Hutchings <ben.hutchings@...ethink.co.uk>, Christoph Hellwig <hch@....de>, Ming Lei <ming.lei@...hat.com>, Jens Axboe <axboe@...nel.dk> Subject: [PATCH 4.9 02/51] Revert "bsg-lib: dont free job in bsg_prepare_job" 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> This reverts commit eb4375e1969c48d454998b2a284c2e6a5dc9eb68 which was commit f507b54dccfd8000c517d740bc45f20c74532d18 upstream. Ben reports: That function doesn't exist here (it was introduced in 4.13). Instead, this backport has modified bsg_create_job(), creating a leak. Please revert this on the 3.18, 4.4 and 4.9 stable branches. So I'm dropping it from here. Reported-by: Ben Hutchings <ben.hutchings@...ethink.co.uk> Cc: Christoph Hellwig <hch@....de> Cc: Ming Lei <ming.lei@...hat.com> Cc: Jens Axboe <axboe@...nel.dk> Signed-off-by: Greg Kroah-Hartman gregkh@...uxfoundation.org --- block/bsg-lib.c | 1 + 1 file changed, 1 insertion(+) --- a/block/bsg-lib.c +++ b/block/bsg-lib.c @@ -147,6 +147,7 @@ static int bsg_create_job(struct device failjob_rls_rqst_payload: kfree(job->request_payload.sg_list); failjob_rls_job: + kfree(job); return -ENOMEM; }
Powered by blists - more mailing lists