lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Oct 2017 17:22:07 +0300 From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> To: Nayna Jain <nayna@...ux.vnet.ibm.com> Cc: linux-integrity@...r.kernel.org, zohar@...ux.vnet.ibm.com, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org, peterhuewe@....de, tpmdd@...horst.net, jgunthorpe@...idianresearch.com, patrickc@...ibm.com Subject: Re: [PATCH v4 4/4] tpm: use tpm_msleep() value as max delay On Tue, Oct 17, 2017 at 04:32:32PM -0400, Nayna Jain wrote: > Currently, tpm_msleep() uses delay_msec as the minimum value in > usleep_range. However, that is the maximum time we want to wait. > The function is modified to use the delay_msec as the maximum > value, not the minimum value. > > After this change, performance on a TPM 1.2 with an 8 byte > burstcount for 1000 extends improved from ~9sec to ~8sec. > > Fixes: 3b9af007869("tpm: replace msleep() with usleep_range() in TPM 1.2/ > 2.0 generic drivers") > > Signed-off-by: Nayna Jain <nayna@...ux.vnet.ibm.com> > Acked-by: Mimi Zohar <zohar@...ux.vnet.ibm.com> > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> > --- > drivers/char/tpm/tpm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 4fc83ac7abeb..644de70de2cc 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -528,8 +528,8 @@ int tpm_pm_resume(struct device *dev); > > static inline void tpm_msleep(unsigned int delay_msec) > { > - usleep_range(delay_msec * 1000, > - (delay_msec * 1000) + TPM_TIMEOUT_RANGE_US); > + usleep_range((delay_msec * 1000) - TPM_TIMEOUT_RANGE_US, > + delay_msec * 1000); > }; > > struct tpm_chip *tpm_chip_find_get(int chip_num); > -- > 2.13.3 > Tested-by: Jarkko Sakkinen <jarkkko.sakkinen@...ux.intel.com> /Jarkko
Powered by blists - more mailing lists