linux-kernel - Re: [PATCH 1/1] time: clocksource: use setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 16:30:18 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Allen Pais <allen.lkml@...il.com>
cc:     linux-kernel@...r.kernel.org, john.stultz@...aro.org,
        sboyd@...eaurora.org
Subject: Re: [PATCH 1/1] time: clocksource: use setup_timer() helper.

On Thu, 21 Sep 2017, Allen Pais wrote:

>     Use setup_timer function instead of initializing timer with the
>     function and data fields.
> 
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---
>  kernel/time/clocksource.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index 03918a1..5b51d5b 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -290,8 +290,7 @@ static inline void clocksource_start_watchdog(void)
>  {
>  	if (watchdog_running || !watchdog || list_empty(&watchdog_list))
>  		return;
> -	init_timer(&watchdog_timer);
> -	watchdog_timer.function = clocksource_watchdog;
> +	setup_timer(&watchdog_timer, clocksource_watchdog, 0UL);

We changed this to use the timer_setup() function. Please resend.

Thanks,

	tglx