linux-kernel - Re: [PATCH v2] driver core: Move device_links_purge() after bus_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4cd28ce-5066-2cc4-2202-700231833b89@intel.com>
Date:   Thu, 19 Oct 2017 16:56:19 +0200
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, briannorris@...omium.org,
        heiko@...ech.de, gregkh@...uxfoundation.org,
        dmitry.torokhov@...il.com, rjw@...ysocki.net,
        dianders@...omium.org, tfiga@...omium.org, broonie@...nel.org,
        seanpaul@...omium.org, thierry.reding@...il.com
Subject: Re: [PATCH v2] driver core: Move device_links_purge() after
 bus_remove_device()

On 10/19/2017 3:32 AM, Jeffy Chen wrote:
> The current ordering of code in device_del() triggers a WARN_ON()
> in device_links_purge(), because of an unexpected link status.
>
> The device_links_unbind_consumers() call in device_release_driver()
> has to take place before device_links_purge() for the status of all
> links to be correct, so move the device_links_purge() call in
> device_del() after the invocation of bus_remove_device() which calls
> device_release_driver().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

It has not been signed off by me, so you should not have added the line 
above.

> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>

For the patch itself and the changelog *except* for the S-o-b line:

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>
> Changes in v2:
> Update commit message provided by Rafael.
>
>   drivers/base/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 12ebd055724c..2e683cdf4a08 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -1958,7 +1958,6 @@ void device_del(struct device *dev)
>   		blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
>   					     BUS_NOTIFY_DEL_DEVICE, dev);
>   
> -	device_links_purge(dev);
>   	dpm_sysfs_remove(dev);
>   	if (parent)
>   		klist_del(&dev->p->knode_parent);
> @@ -1986,6 +1985,7 @@ void device_del(struct device *dev)
>   	device_pm_remove(dev);
>   	driver_deferred_probe_del(dev);
>   	device_remove_properties(dev);
> +	device_links_purge(dev);
>   
>   	/* Notify the platform of the removal, in case they
>   	 * need to do anything...