lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Oct 2017 17:29:12 +0200 From: Arnd Bergmann <arnd@...db.de> To: Jan Kara <jack@...e.cz> Cc: y2038 Mailman List <y2038@...ts.linaro.org>, Al Viro <viro@...iv.linux.org.uk>, Deepa Dinamani <deepa.kernel@...il.com>, Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>, Anders Larsen <al@...rsen.net>, "# 3.4.x" <stable@...r.kernel.org>, David Howells <dhowells@...hat.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/2] isofs: fix timestamps beyond 2027 On Thu, Oct 19, 2017 at 5:17 PM, Jan Kara <jack@...e.cz> wrote: > On Thu 19-10-17 16:47:48, Arnd Bergmann wrote: >> isofs uses a 'char' variable to load the number of years since >> 1900 for an inode timestamp. On architectures that use a signed >> char type by default, this results in an invalid date for >> anything beyond 2027. >> >> This changes the function argument to a 'u8' array, which >> is defined the same way on all architectures, and unambiguously >> lets us use years until 2155. >> >> This should be backported to all kernels that might still be >> in use by that date. >> >> Cc: stable@...r.kernel.org >> Signed-off-by: Arnd Bergmann <arnd@...db.de> > ... >> -int iso_date(char * p, int flag) >> +int iso_date(u8 *p, int flag) >> { >> int year, month, day, hour, minute, second, tz; >> int crtime; >> >> - year = p[0]; >> + year = (int)(u8)p[0]; > > The cast seems unnecessary now? > Sorry, I must have rebased the patch incorrectly, this was intended to be removed of course. Arnd
Powered by blists - more mailing lists