linux-kernel - Re: [PATCH 1/4] kaslr: parse the extended movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <804f8a19-f005-f6a5-0cf4-bd191ff01d37@cn.fujitsu.com>
Date:   Fri, 20 Oct 2017 13:33:16 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Chao Fan <fanc.fnst@...fujitsu.com>
CC:     <linux-kernel@...r.kernel.org>, <x86@...nel.org>, <hpa@...or.com>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bhe@...hat.com>,
        <keescook@...omium.org>, <indou.takao@...fujitsu.com>,
        <caoj.fnst@...fujitsu.com>
Subject: Re: [PATCH 1/4] kaslr: parse the extended
 movable_node=nn[KMG]@ss[KMG]

[...]
>>>>>
>>>>> +#ifdef CONFIG_MEMORY_HOTPLUG
>>>>> +static void mem_mark_immovable(char *str)
>>>>> +{
>>>>> +	int i = 0;
>>>>> +
>>>>
>>>> you have use num_immovable_region, 'i' is useless. just remove it.
>>>
>>> Using num_immovable_region makes code too long. Using i will be
>>> clear and make sure shoter than 80 characters.
>>
>> Oh, God, that's horrific. Did you find that your code is wrong?
>>
>> num_immovable_region will be reset each time.
>
> Did you test?
>

you can try with more than one movable_node, eg:

"...movable_node=128G@...G movable_node=128G@...G..."

then, you will find the problem of you code.

Thanks,
	dou