linux-kernel - Re: [PATCH net-next] net: sched: cls_u32: use hash_ptr() for tc_u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171020.083623.347659428573746599.davem@davemloft.net>
Date:   Fri, 20 Oct 2017 08:36:23 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: sched: cls_u32: use hash_ptr() for
 tc_u_hash

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 18 Oct 2017 10:33:37 +0200

> After the change to the tp hash, we now get a build warning
> on 32-bit architectures:
> 
> net/sched/cls_u32.c: In function 'tc_u_hash':
> net/sched/cls_u32.c:338:17: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>   return hash_64((u64) tp->chain->block, U32_HASH_SHIFT);
> 
> Using hash_ptr() instead of hash_64() lets us drop the cast
> and fixes the warning while still resulting in the same hash
> value.
> 
> Fixes: 7fa9d974f3c2 ("net: sched: cls_u32: use block instead of q in tc_u_common")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.