linux-kernel - Re: [PATCH v16 09/10] x86/arch_prctl: Selftest for ARCH_[GET|SET]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1710201050290.1882@nanos>
Date:   Fri, 20 Oct 2017 10:53:28 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kyle Huey <me@...ehuey.com>
cc:     Wanpeng Li <kernellwp@...il.com>,
        Robert O'Callahan <robert@...llahan.org>,
        Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Shuah Khan <shuah@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Len Brown <len.brown@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Dmitry Safonov <dsafonov@...tuozzo.com>,
        David Matlack <dmatlack@...gle.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Andi Kleen <andi@...stfloor.org>,
        Grzegorz Andrejczuk <grzegorz.andrejczuk@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-devel@...ts.sourceforge.net>,
        "open list:USER-MODE LINUX (UML)" 
        <user-mode-linux-user@...ts.sourceforge.net>,
        "open list:FILESYSTEMS (VFS and infrastructure)" 
        <linux-fsdevel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, kvm <kvm@...r.kernel.org>
Subject: Re: [PATCH v16 09/10] x86/arch_prctl: Selftest for
 ARCH_[GET|SET]_CPUID

On Tue, 10 Oct 2017, Kyle Huey wrote:

> On Tue, Oct 10, 2017 at 8:35 PM, Wanpeng Li <kernellwp@...il.com> wrote:
> > Hi Kyle,
> > 2017-03-20 16:16 GMT+08:00 Kyle Huey <me@...ehuey.com>:
> >> Test disabling and reenabling the cpuid instruction via the new arch_prctl
> >> ARCH_SET_CPUID, retrieving the current state via ARCH_GET_CPUID, and the
> >> expected behaviors across fork() and exec().
> >>
> >> Signed-off-by: Kyle Huey <khuey@...ehuey.com>
> >> ---
> >>  tools/testing/selftests/x86/Makefile      |   2 +-
> >>  tools/testing/selftests/x86/cpuid_fault.c | 251 ++++++++++++++++++++++++++++++
> >
> > I'm not sure why this commit is not merged to upstream. I test
> > 4.14-rc3 w/ this testcase on a haswell client, however I encounter the
> > below splat, any idea?
> 
> Thanks for pointing out that this never got merged.  That's quite
> disappointing, especially after reviewers insisted I write this test.

Sorry about that. I expected it to be picked up by Shuah and I assumed the
same happend the other way round.

Can you please resubmit?

Thanks,

	tglx