linux-kernel - Re: [tip:irq/core] irqchip/meson: Disable COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1508491710.3616.38.camel@baylibre.com>
Date:   Fri, 20 Oct 2017 11:28:30 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     marc.zyngier@....com, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
        hkallweit1@...il.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/core] irqchip/meson: Disable COMPILE_TEST

On Fri, 2017-10-20 at 02:21 -0700, tip-bot for Thomas Gleixner wrote:
> Commit-ID:  d9ee91c1b1fe56b905b767f4a0063d3624e1a1cf
> Gitweb:     https://git.kernel.org/tip/d9ee91c1b1fe56b905b767f4a0063d3624e1a1c
> f
> Author:     Thomas Gleixner <tglx@...utronix.de>
> AuthorDate: Fri, 20 Oct 2017 11:15:36 +0200
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Fri, 20 Oct 2017 11:17:17 +0200
> 
> irqchip/meson: Disable COMPILE_TEST
> 
> The driver fails to compile with CONFIG_COMPILE_TEST=y on x86:
> 
> irq-meson-gpio.c: In function ‘meson_gpio_irq_parse_dt’:
> irq-meson-gpio.c:343:8: error: implicit declaration of function
> 			       ‘of_property_read_variable_u32_array’
>   ret = of_property_read_variable_u32_array(node,
> 
> Adding COMPILE_TEST to a driver requires at least compile testing it for
> x86....

Indeed, sorry about that.
Thanks for fixing.

> 
> Reported-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Heiner Kallweit <hkallweit1@...il.com>
> Cc: Jerome Brunet <jbrunet@...libre.com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 1cb3940..85d0fb2 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -326,7 +326,7 @@ config IRQ_UNIPHIER_AIDET
>  
>  config MESON_IRQ_GPIO
>         bool "Meson GPIO Interrupt Multiplexer"
> -       depends on ARCH_MESON || COMPILE_TEST
> +       depends on ARCH_MESON
>         select IRQ_DOMAIN
>         select IRQ_DOMAIN_HIERARCHY
>         help