linux-kernel - Re: [PATCH 1/4] kaslr: parse the extended movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171020093421.GF5635@localhost.localdomain>
Date:   Fri, 20 Oct 2017 17:34:22 +0800
From:   Chao Fan <fanc.fnst@...fujitsu.com>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
CC:     <linux-kernel@...r.kernel.org>, <x86@...nel.org>, <hpa@...or.com>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bhe@...hat.com>,
        <keescook@...omium.org>, <indou.takao@...fujitsu.com>,
        <caoj.fnst@...fujitsu.com>
Subject: Re: [PATCH 1/4] kaslr: parse the extended
 movable_node=nn[KMG]@ss[KMG]

On Fri, Oct 20, 2017 at 01:33:16PM +0800, Dou Liyang wrote:
>[...]
>> > > > > 
>> > > > > +#ifdef CONFIG_MEMORY_HOTPLUG
>> > > > > +static void mem_mark_immovable(char *str)
>> > > > > +{
>> > > > > +	int i = 0;
>> > > > > +
>> > > > 
>> > > > you have use num_immovable_region, 'i' is useless. just remove it.
>> > > 
>> > > Using num_immovable_region makes code too long. Using i will be
>> > > clear and make sure shoter than 80 characters.
>> > 
>> > Oh, God, that's horrific. Did you find that your code is wrong?
>> > 
>> > num_immovable_region will be reset each time.
>> 
>> Did you test?
>> 
>
>you can try with more than one movable_node, eg:
>
>"...movable_node=128G@...G movable_node=128G@...G..."
>

Yes, you are right.
I thought users will specify the regions like this:
movable_node=1G@2G,1G@4G
If users want to use
movable_node=1G@2G movable_node=1G@4G
Your suggestion is helpful and I will update it.

Thanks,
Chao Fan
>then, you will find the problem of you code.
>
>Thanks,
>	dou