linux-kernel - Re: [tip:x86/timers] x86: Don't include asm/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1BVtTQGtj=CmQo4zn4qGAHqDED1eqkFOm-zgXj-kN97A@mail.gmail.com>
Date:   Fri, 20 Oct 2017 13:37:30 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Joerg Roedel <joro@...tes.org>,
        "H. Peter Anvin" <hpa@...or.com>, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/timers] x86: Don't include asm/x86_init.h in asm/setup.h

On Fri, Oct 20, 2017 at 1:11 PM, Ingo Molnar <mingo@...nel.org> wrote:
>>  #include <asm/iommu_table.h>
>> +#include <asm/x86_init.h>
>>
>>  #include "irq_remapping.h"
>
> This breaks the IA64 build:
>
>   drivers/iommu/dmar.c:44:26: fatal error: asm/x86_init.h: No such file or directory

I've sent a fixup to add an #ifdef around it now. Alternatively, we
could include
it implicitly in asm/iommu_table.h, which would avoid the #ifdef but
seem a little
hacky.

      Arnd