linux-kernel - Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface for drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Oct 2017 15:21:38 +0200
From:   Greg KH <greg@...ah.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        pali.rohar@...il.com, rjw@...ysocki.net, mjg59@...gle.com,
        hch@....de, Alan Cox <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
 for drivers

On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> +	wblock = container_of(wdev, struct wmi_block, dev);
> +	if (!wblock)
> +		return -ENODEV;

How can container_of() ever return NULL?  If so, you have a very odd
memory layout...

> +	list_for_each_entry_safe(wblock, next, &wmi_block_list, list) {
> +		wdriver = container_of(wblock->dev.dev.driver,
> +					struct wmi_driver, driver);
> +		if (!wdriver)
> +			continue;

Same here.  And other places in this file.

thanks,

greg k-h