linux-kernel - Re: [rcu:rcu/alpha 1/19] arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171020164321.GB7287@arm.com>
Date:   Fri, 20 Oct 2017 17:43:22 +0100
From:   Will Deacon <will.deacon@....com>
To:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        linux-kernel@...r.kernel.org
Subject: Re: [rcu:rcu/alpha 1/19] arch/sparc/include/asm/ptrace.h:102:6:
 error: implicit declaration of function 'unlikely'

On Fri, Oct 20, 2017 at 09:39:07AM -0700, Paul E. McKenney wrote:
> On Fri, Oct 20, 2017 at 10:36:37AM +0100, Will Deacon wrote:
> > On Fri, Oct 20, 2017 at 05:17:54AM +0800, kbuild test robot wrote:
> > >    In file included from arch/sparc/include/asm/processor_64.h:18:0,
> > >                     from arch/sparc/include/asm/processor.h:4,
> > >                     from include/linux/prefetch.h:14,
> > >                     from drivers/net/ethernet/emulex/benet/be_main.c:18:
> > >    arch/sparc/include/asm/ptrace.h: In function 'regs_get_register':
> > > >> arch/sparc/include/asm/ptrace.h:102:6: error: implicit declaration of function 'unlikely' [-Werror=implicit-function-declaration]
> > >      if (unlikely(offset >= MAX_REG_OFFSET))
> > >          ^~~~~~~~
> > >    cc1: some warnings being treated as errors
> > 
> > I'm not sure why I didn't get these reports from my tree, but there's a
> > fixup patch below.
> 
> There is some RANDCONFIG action in kbuild test robot, so your mileage
> can vary.  Thank you for the fix, please see below.

True, I forgot about that.

> > --->8
> > 
> > >From db5984f0878a013857299acd7e0fa406905d973c Mon Sep 17 00:00:00 2001
> > From: Will Deacon <will.deacon@....com>
> > Date: Fri, 20 Oct 2017 10:21:18 +0100
> > Subject: [PATCH] sparc64: ptrace: Include linux/compiler.h for unlikely()
> > 
> > Compiler.g is no longer implicitly included in asm/ptrace.h so pull it
> > in explicitly to get a definition for the unlikely() macro.
> > 
> > Reported-by: kbuild test robot <fengguang.wu@...el.com>
> > Signed-off-by: Will Deacon <will.deacon@....com>
> > ---
> >  arch/sparc/include/asm/ptrace.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/sparc/include/asm/ptrace.h b/arch/sparc/include/asm/ptrace.h
> > index d73428e4333c..b383484edcd3 100644
> > --- a/arch/sparc/include/asm/ptrace.h
> > +++ b/arch/sparc/include/asm/ptrace.h
> > @@ -6,6 +6,7 @@
> >  #if defined(__sparc__) && defined(__arch64__)
> >  #ifndef __ASSEMBLY__
> > 
> > +#include <linux/compiler.h>
> >  #include <linux/threads.h>
> >  #include <asm/switch_to.h>
> 
> I folded this into your first commit ("linux/compiler.h: Split into
> compiler.h and compiler-types.h") like so.  Does that work for you?

Yes, thanks! There's another fix for arch/um/ too (I replied to it this
morning).

Will