lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Oct 2017 11:24:48 -0700 From: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com> To: Borislav Petkov <bp@...e.de> Cc: Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, "H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, Brian Gerst <brgerst@...il.com>, Chris Metcalf <cmetcalf@...lanox.com>, Dave Hansen <dave.hansen@...ux.intel.com>, Paolo Bonzini <pbonzini@...hat.com>, Masami Hiramatsu <mhiramat@...nel.org>, Huang Rui <ray.huang@....com>, Jiri Slaby <jslaby@...e.cz>, Jonathan Corbet <corbet@....net>, "Michael S. Tsirkin" <mst@...hat.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Vlastimil Babka <vbabka@...e.cz>, Chen Yucong <slaoub@...il.com>, "Ravi V. Shankar" <ravi.v.shankar@...el.com>, Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, x86@...nel.org, ricardo.neri@...el.com, Adam Buchbinder <adam.buchbinder@...il.com>, Colin Ian King <colin.king@...onical.com>, Lorenzo Stoakes <lstoakes@...il.com>, Qiaowei Ren <qiaowei.ren@...el.com>, Arnaldo Carvalho de Melo <acme@...hat.com>, Adrian Hunter <adrian.hunter@...el.com>, Kees Cook <keescook@...omium.org>, Thomas Garnier <thgarnie@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com> Subject: Re: [PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings On Fri, Oct 20, 2017 at 07:12:30PM +0200, Borislav Petkov wrote: > On Tue, Oct 03, 2017 at 08:54:22PM -0700, Ricardo Neri wrote: > > The new function get_addr_ref_32() is almost identical to the existing > > function insn_get_addr_ref() (used for 64-bit addresses); except for the > > differences mentioned above. For the sake of simplicity and readability, > > it is better to use two separate functions. > > You're kidding, right? > > You're not adding another small function - this new one is just as big. And > almost identical. > > So if you split the whole handling into helpers - for example, each > if-clause is doing very similar things - you can carve out the repeating > pieces into helpers and then call them each time with the respective > parameters, you can get rid of all that needless duplication. I will create these helper functions. This change and your suggestion in patch 18 will impact other patches in the series (e.g., the function get_addr_ref_16() in patch 22). Would it make sense to submit a v10 and resume review there? Also, do you think I am still on-time to make it to v4.15? Thanks and BR, Ricardo > > -- > Regards/Gruss, > Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) > --
Powered by blists - more mailing lists