linux-kernel - Re: hwmon: (asc7621): remove redundant assignment to newval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171021155749.GA11642@roeck-us.net>
Date:   Sat, 21 Oct 2017 08:57:49 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     George Joseph <george.joseph@...rview5.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: hwmon: (asc7621): remove redundant assignment to newval

On Wed, Oct 18, 2017 at 01:10:38PM +0100, Colin Ian King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The setting of newval to zero is redundant as the following if/else
> stanzas will always update newval to a new value. Remove the
> redundant setting, cleans up clang build warning:
> 
> drivers/hwmon/asc7621.c:582:2: warning: Value stored to 'newval' is
> never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/asc7621.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asc7621.c b/drivers/hwmon/asc7621.c
> index 4875e99b59c9..6d34c05a4f83 100644
> --- a/drivers/hwmon/asc7621.c
> +++ b/drivers/hwmon/asc7621.c
> @@ -579,7 +579,6 @@ static ssize_t show_pwm_enable(struct device *dev,
>  	mutex_unlock(&data->update_lock);
>  
>  	val = config | (altbit << 3);
> -	newval = 0;
>  
>  	if (val == 3 || val >= 10)
>  		newval = 255;