linux-kernel - Re: [PATCH] iio: adc: make array ch_to_mux static, makes object code smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171021175809.3e036d39@archlinux>
Date:   Sat, 21 Oct 2017 17:58:09 +0100
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     Colin King <colin.king@...onical.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: make array ch_to_mux static, makes object
 code smaller

On Thu, 19 Oct 2017 15:46:22 +0200
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate const array ch_to_mux on the stack, instead
> make it static. Makes the object code smaller by over 200 bytes:
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   12663	   1648	    128	  14439	   3867	drivers/iio/adc/ti-adc12138.o
> 
> After
>    text	   data	    bss	    dec	    hex	filename
>   12353	   1744	    128	  14225	   3791	drivers/iio/adc/ti-adc12138.o
> 
> (gcc version 7.2.0 x86_64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Thanks.  I added the driver name to the title though as people tend
to scan lists of commits to see if there is anything they care about
and this only effects on driver rather than all adcs.

Applied to the togreg branch of iio.git and pusehd out as testing for the
autobuilders to play with it.

thanks,

Jonathan
> ---
>  drivers/iio/adc/ti-adc12138.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti-adc12138.c b/drivers/iio/adc/ti-adc12138.c
> index bf890244789a..703d68ae96b7 100644
> --- a/drivers/iio/adc/ti-adc12138.c
> +++ b/drivers/iio/adc/ti-adc12138.c
> @@ -164,7 +164,7 @@ static int __adc12138_start_conv(struct adc12138 *adc,
>  				 void *data, int len)
>  
>  {
> -	const u8 ch_to_mux[] = { 0, 4, 1, 5, 2, 6, 3, 7 };
> +	static const u8 ch_to_mux[] = { 0, 4, 1, 5, 2, 6, 3, 7 };
>  	u8 mode = (ch_to_mux[channel->channel] << 4) |
>  		  (channel->differential ? 0 : 0x80);
>