linux-kernel - Re: [PATCH net] hv_sock: add locking in the open/close/release code paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171021.022129.807124847963198670.davem@davemloft.net>
Date:   Sat, 21 Oct 2017 02:21:29 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     decui@...rosoft.com
Cc:     netdev@...r.kernel.org, sthemmin@...rosoft.com, kys@...rosoft.com,
        devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
        vkuznets@...hat.com, haiyangz@...rosoft.com, cavery@...hat.com,
        rolf.neugebauer@...ker.com, marcelo.cerri@...onical.com,
        Jork.Loeser@...rosoft.com
Subject: Re: [PATCH net] hv_sock: add locking in the open/close/release
 code paths

From: Dexuan Cui <decui@...rosoft.com>
Date: Thu, 19 Oct 2017 03:33:14 +0000

> 
> Without the patch, when hvs_open_connection() hasn't completely established
> a connection (e.g. it has changed sk->sk_state to SS_CONNECTED, but hasn't
> inserted the sock into the connected queue), vsock_stream_connect() may see
> the sk_state change and return the connection to the userspace, and next
> when the userspace closes the connection quickly, hvs_release() may not see
> the connection in the connected queue; finally hvs_open_connection()
> inserts the connection into the queue, but we won't be able to purge the
> connection for ever.
> 
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>

Applied.