lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Oct 2017 16:59:09 +0530 From: Vinod Koul <vinod.koul@...el.com> To: Mark Brown <broonie@...nel.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, LKML <linux-kernel@...r.kernel.org>, ALSA <alsa-devel@...a-project.org>, Takashi <tiwai@...e.de>, Pierre <pierre-louis.bossart@...ux.intel.com>, Sanyog Kale <sanyog.r.kale@...el.com>, Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com, alan@...ux.intel.com, Charles Keepax <ckeepax@...nsource.cirrus.com>, Sagar Dharia <sdharia@...eaurora.org>, srinivas.kandagatla@...aro.org, plai@...eaurora.org, Sudheer Papothi <spapothi@...eaurora.org> Subject: Re: [PATCH 02/14] soundwire: Add SoundWire bus type On Sat, Oct 21, 2017 at 10:03:48AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:18AM +0530, Vinod Koul wrote: > > > + ret = dev_pm_domain_attach(dev, false); > > + if (ret) { > > + dev_err(dev, "Failed to attach PM domain: %d\n", ret); > > + return ret; > > + } > > + > > + ret = drv->probe(slave, id); > > + if (ret) { > > + dev_err(dev, "Probe of %s failed: %d\n", drv->name, ret); > > + return ret; > > + } > > We don't detach the power domain if the probe fails. we should, thanks for spotting -- ~Vinod
Powered by blists - more mailing lists