linux-kernel - Re: [PATCH 11/14] soundwire: cdns: Add cadence module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Oct 2017 17:24:54 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Takashi <tiwai@...e.de>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH 11/14] soundwire: cdns: Add cadence module

On Sat, Oct 21, 2017 at 10:52:01AM +0100, Mark Brown wrote:
> On Thu, Oct 19, 2017 at 08:33:27AM +0530, Vinod Koul wrote:
> 
> > Cadence IP implements SoundWire Master. Add base cadence module
> > initialization and interrupt handling
> 
> It's probably worth saying something about how this isn't a device
> driver but rather a library for device drivers.

Yes you are right, I will update this to clarify

> 
> > +	if (int_status & CDNS_MCP_INT_CTRL_CLASH) {
> > +
> > +		/* Slave is driving bit slot during control word */
> > +		dev_err_ratelimited(cdns->dev, "Bus clash for control word\n");
> > +		int_status |= CDNS_MCP_INT_CTRL_CLASH;
> > +	}
> 
> So with this (and the other error flags) we check to see if the bit is
> set, print an error and then set the bit we were looking for in the same
> variable we just checked?

no this doesnt look right, I will fix it up.

-- 
~Vinod