linux-kernel - Re: [f2fs-dev] [PATCH 1/2] f2fs: retry ENOMEM for quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3000c803-d3a4-209f-d1eb-88bc61bd316b@kernel.org>
Date:   Sun, 22 Oct 2017 23:02:18 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: retry ENOMEM for quota_read|write

On 2017/10/20 0:56, Jaegeuk Kim wrote:
> This gives another chance to read or write quota data.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

> ---
>  fs/f2fs/super.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index fc3b74e53670..2c6e9adce464 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1351,8 +1351,13 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data,
>  		tocopy = min_t(unsigned long, sb->s_blocksize - offset, toread);
>  repeat:
>  		page = read_mapping_page(mapping, blkidx, NULL);
> -		if (IS_ERR(page))
> +		if (IS_ERR(page)) {
> +			if (PTR_ERR(page) == -ENOMEM) {
> +				congestion_wait(BLK_RW_ASYNC, HZ/50);
> +				goto repeat;
> +			}
>  			return PTR_ERR(page);
> +		}
>  
>  		lock_page(page);
>  
> @@ -1395,10 +1400,14 @@ static ssize_t f2fs_quota_write(struct super_block *sb, int type,
>  	while (towrite > 0) {
>  		tocopy = min_t(unsigned long, sb->s_blocksize - offset,
>  								towrite);
> -
> +retry:
>  		err = a_ops->write_begin(NULL, mapping, off, tocopy, 0,
>  							&page, NULL);
>  		if (unlikely(err)) {
> +			if (err == -ENOMEM) {
> +				congestion_wait(BLK_RW_ASYNC, HZ/50);
> +				goto retry;
> +			}
>  			if (len == towrite)
>  				return err;
>  			break;
>