linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: turn quota off when error occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d150c646-64fd-84a0-4fc7-837b9efcb85e@kernel.org>
Date:   Sun, 22 Oct 2017 23:16:17 +0800
From:   Chao Yu <chao@...nel.org>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: turn quota off when error occurs

On 2017/10/20 23:53, Jaegeuk Kim wrote:
> Before changing readonly, it needs to turn quota off.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> ---
>  fs/f2fs/checkpoint.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
> index 201608281681..ff74665d7f2d 100644
> --- a/fs/f2fs/checkpoint.c
> +++ b/fs/f2fs/checkpoint.c
> @@ -29,6 +29,7 @@ struct kmem_cache *inode_entry_slab;
>  void f2fs_stop_checkpoint(struct f2fs_sb_info *sbi, bool end_io)
>  {
>  	set_ckpt_flags(sbi, CP_ERROR_FLAG);
> +	f2fs_quota_off_umount(sb);
>  	sbi->sb->s_flags |= MS_RDONLY;
>  	if (!end_io)

Oh, f2fs_stop_checkpoint can be called from end_io, how about adding
f2fs_quota_off_umount here?

Thanks,

>  		f2fs_flush_merged_writes(sbi);
>