linux-kernel - Re: [PATCH 07/14] regmap: Add SoundWire bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Oct 2017 15:16:39 +0200
From:   Mark Brown <broonie@...nel.org>
To:     Alan Cox <alan@...ux.intel.com>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Takashi <tiwai@...e.de>,
        Pierre <pierre-louis.bossart@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Shreyas NC <shreyas.nc@...el.com>, patches.audio@...el.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [PATCH 07/14] regmap: Add SoundWire bus support

On Mon, Oct 23, 2017 at 12:56:27PM +0100, Alan Cox wrote:
> On Sat, 2017-10-21 at 10:34 +0100, Mark Brown wrote:
> > On Thu, Oct 19, 2017 at 08:33:23AM +0530, Vinod Koul wrote:

> > > +EXPORT_SYMBOL(__regmap_init_sdw);

> > ...this is just an obvious attempt to allow non-GPL code to directly
> > use
> > GPL code.

> There's nothing in the GPL about EXPORT_SYMBOL. If its built GPL
> dependent then it depends upon GPL code so is GPL.

My point is that in the context of this very thin wrapper around an API
that's entirely EXPORT_SYMBOL_GPL() dropping the _GPL() from the export
looks like it's going to enable questionable usage, probably in this
case it's just an oversight caused by all the other non-GPL exports in
the Slimbus code rather than something that's intentional.  This seems
particularly important here in something that's for drivers rather than
the subsystem itself since people might make assumptions (justified or
not) based on the EXPORT_SYMBOL() exports.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)