linux-kernel - Re: [PATCH V3] selftests/vm: Add tests validating mremap mirror functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <958ed0c9-6c52-ce4e-e347-eb5d11e84e5f@linux.vnet.ibm.com>
Date:   Mon, 23 Oct 2017 08:35:54 +0530
From:   Anshuman Khandual <khandual@...ux.vnet.ibm.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>,
        Anshuman Khandual <khandual@...ux.vnet.ibm.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc:     mhocko@...nel.org, shuahkh@....samsung.com,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH V3] selftests/vm: Add tests validating mremap mirror
 functionality

On 10/20/2017 04:54 AM, Mike Kravetz wrote:
> On 10/17/2017 10:55 PM, Anshuman Khandual wrote:
>> This adds two tests to validate mirror functionality with mremap()
>> system call on shared and private anon mappings. After the commit
>> dba58d3b8c5 ("mm/mremap: fail map duplication attempts for private
>> mappings"), any attempt to mirror private anon mapping will fail.
>>
>> Suggested-by: Mike Kravetz <mike.kravetz@...cle.com>
>> Signed-off-by: Anshuman Khandual <khandual@...ux.vnet.ibm.com>
> The tests themselves look fine.  However, they are pretty simple and
> could very easily be combined into one 'mremap_mirror.c' file.  I
> would prefer that they be combined, but it is not a deal breaker.
> 
> Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
> 

Hello Andrew/Shuah,

Is this okay or should I resend this patch with both tests folded
into one test case file ?

- Anshuman