linux-kernel - Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e82b159-0031-6781-f21b-b86ce370c8f3@intel.com>
Date:   Tue, 24 Oct 2017 00:35:42 +0800
From:   Zhi Wang <zhi.a.wang@...el.com>
To:     Christos Gkekas <chris.gekas@...il.com>,
        fred gao <fred.gao@...el.com>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915/gvt: Clean up dead code in cmd_parser

Thanks, applied! :)

On 10/16/17 06:32, Christos Gkekas wrote:
> Delete variables 'gma_bottom' that are set but never used.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@...il.com>
> ---
>   drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index 2c0ccbb..d75ce70 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -2511,7 +2511,7 @@ static int command_scan(struct parser_exec_state *s,
>   
>   static int scan_workload(struct intel_vgpu_workload *workload)
>   {
> -	unsigned long gma_head, gma_tail, gma_bottom;
> +	unsigned long gma_head, gma_tail;
>   	struct parser_exec_state s;
>   	int ret = 0;
>   
> @@ -2521,7 +2521,6 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>   
>   	gma_head = workload->rb_start + workload->rb_head;
>   	gma_tail = workload->rb_start + workload->rb_tail;
> -	gma_bottom = workload->rb_start +  _RING_CTL_BUF_SIZE(workload->rb_ctl);
>   
>   	s.buf_type = RING_BUFFER_INSTRUCTION;
>   	s.buf_addr_type = GTT_BUFFER;
> @@ -2557,7 +2556,7 @@ static int scan_workload(struct intel_vgpu_workload *workload)
>   static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>   {
>   
> -	unsigned long gma_head, gma_tail, gma_bottom, ring_size, ring_tail;
> +	unsigned long gma_head, gma_tail, ring_size, ring_tail;
>   	struct parser_exec_state s;
>   	int ret = 0;
>   	struct intel_vgpu_workload *workload = container_of(wa_ctx,
> @@ -2573,7 +2572,6 @@ static int scan_wa_ctx(struct intel_shadow_wa_ctx *wa_ctx)
>   			PAGE_SIZE);
>   	gma_head = wa_ctx->indirect_ctx.guest_gma;
>   	gma_tail = wa_ctx->indirect_ctx.guest_gma + ring_tail;
> -	gma_bottom = wa_ctx->indirect_ctx.guest_gma + ring_size;
>   
>   	s.buf_type = RING_BUFFER_INSTRUCTION;
>   	s.buf_addr_type = GTT_BUFFER;
>