linux-kernel - Re: [PATCH] dmaengine: ioat: Use common error handling code in ioat_xor_val_self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171023165617.GK936@localhost>
Date:   Mon, 23 Oct 2017 22:26:17 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        Geliang Tang <geliangtang@...il.com>,
        Krister Johansen <kjlx@...pleofstupid.com>,
        Pan Bian <bianpan2016@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: ioat: Use common error handling code in
 ioat_xor_val_self_test()

On Mon, Oct 23, 2017 at 08:59:19AM -0700, Dave Jiang wrote:
> On 10/23/2017 12:27 AM, Dan Carpenter wrote:
> > These patches hurt readability.
> > 
> > regards,
> > dan carpenter
> > 
> 
> I agree with Dan. I'm ok with not accepting this patch.

And I have no intention to :)

At least they should explain why or how it help, give the Coccinelle
scripts.. But sadly that is not done ...

-- 
~Vinod