linux-kernel - Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP245DU5KBUWPMebcDtBT6Zz89zfC3juMOA+hjow8PRJV02gCw@mail.gmail.com>
Date:   Mon, 23 Oct 2017 10:26:29 +0530
From:   Amit Kucheria <amit.kucheria@...aro.org>
To:     Timur Tabi <timur@...eaurora.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Olof Johansson <olof@...om.net>, Rob Herring <robh@...nel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/4] arm64: defconfig: enable new trigger modes for leds

On Thu, Oct 19, 2017 at 8:54 PM, Timur Tabi <timur@...eaurora.org> wrote:
> On 10/18/17 3:57 PM, Amit Kucheria wrote:
>>
>> Enable panic and disk activity triggers to tie to LED activity
>
>
> Could you provide some explanation as to why we want this enabled for ARM64?
> I don't have a problem with the change itself, but I think patch
> descriptions for defconfig changes should include justifications.

Indeed.

The blurb should be modified as follows:

"Most development boards and devices have one or more LEDs. It is
useful during debugging if they can be wired to show different
behaviours such as disk or cpu activity or a load-average dependent
heartbeat. Enable panic and disk activity triggers so they can be tied
to LED activity during debugging as well."

If this blurb works, I'll send out another version.