linux-kernel - Re: [PATCH] wimax/i2400m: Remove VLAIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171024194659.GC96615@google.com>
Date:   Tue, 24 Oct 2017 12:46:59 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>
Cc:     linux-wimax@...el.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Behan Webster <behanw@...verseincode.com>,
        Mark Charlebois <charlebm@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] wimax/i2400m: Remove VLAIS

El Mon, Oct 09, 2017 at 12:41:53PM -0700 Matthias Kaehlcke ha dit:

> From: Behan Webster <behanw@...verseincode.com>
> 
> Convert Variable Length Array in Struct (VLAIS) to valid C by converting
> local struct definition to use a flexible array. The structure is only
> used to define a cast of a buffer so the size of the struct is not used
> to allocate storage.
> 
> Signed-off-by: Behan Webster <behanw@...verseincode.com>
> Signed-off-by: Mark Charebois <charlebm@...il.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  drivers/net/wimax/i2400m/fw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c
> index c9c711dcd0e6..a89b5685e68b 100644
> --- a/drivers/net/wimax/i2400m/fw.c
> +++ b/drivers/net/wimax/i2400m/fw.c
> @@ -652,7 +652,7 @@ static int i2400m_download_chunk(struct i2400m *i2400m, const void *chunk,
>  	struct device *dev = i2400m_dev(i2400m);
>  	struct {
>  		struct i2400m_bootrom_header cmd;
> -		u8 cmd_payload[chunk_len];
> +		u8 cmd_payload[];
>  	} __packed *buf;
>  	struct i2400m_bootrom_header ack;

ping

any comments on this?