linux-kernel - Re: [PATCH] ALSA: wavefront: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKf6s6OemAbvDXHFi6dRTM+UDjPCothMXjcE+qkOQxfmw@mail.gmail.com>
Date:   Tue, 24 Oct 2017 13:08:54 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: wavefront: Convert timers to use timer_setup()

On Tue, Oct 24, 2017 at 12:32 PM, Takashi Iwai <tiwai@...e.de> wrote:
> On Tue, 24 Oct 2017 17:35:09 +0200,
> Kees Cook wrote:
>>
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Jaroslav Kysela <perex@...ex.cz>
>> Cc: Takashi Iwai <tiwai@...e.com>
>> Cc: Takashi Sakamoto <o-takashi@...amocchi.jp>
>> Cc: alsa-devel@...a-project.org
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Thanks, applied.
>
> I guess we may deduce the card pointer from substream_output[], but
> this approach will be simpler in the end.

Yeah, I looked at that as an option, and I couldn't tell if the
lifetime might change out from under the timer, so I opted for an
explicit pointer since that's no worse than what the old struct
timer_list did anyway. :)

Thanks!

-Kees

-- 
Kees Cook
Pixel Security