linux-kernel - Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d6395dc-d355-627e-e0f6-0e8ad7207f23@wedev4u.fr>
Date:   Wed, 25 Oct 2017 00:25:34 +0200
From:   Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>
To:     Bin Meng <bmeng.cn@...il.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Cc:     Stefan Roese <sr@...x.de>
Subject: Re: [PATCH] spi-nor: intel-spi: Remove EXPERT dependency

Le 24/10/2017 à 09:40, Bin Meng a écrit :
> The idea to have the intel-spi driver dependent on EXPERT was exactly
> because we did not want ordinary users playing with the device and
> inadvertently overwrite their BIOSes (if it is not protected). This
> seems to be superfluous hence remove it.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Bin Meng <bmeng.cn@...il.com>

Applied to the spi-nor/next branch of l2-mtd (reworked a little bit
since the original patch depends on "spi-nor: intel-spi: Fix Kconfig
dependency to LPC_ICH", see below).

Thanks!
> ---
> 
>  drivers/mtd/spi-nor/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index abf453a..be7cfb9 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -90,7 +90,7 @@ config SPI_INTEL_SPI
>  	tristate
>  
>  config SPI_INTEL_SPI_PCI
> -	tristate "Intel PCH/PCU SPI flash PCI driver" if EXPERT
> +	tristate "Intel PCH/PCU SPI flash PCI driver"
>  	depends on X86 && PCI
>  	select SPI_INTEL_SPI
>  	help
> @@ -106,7 +106,7 @@ config SPI_INTEL_SPI_PCI
>  	  will be called intel-spi-pci.
>  
>  config SPI_INTEL_SPI_PLATFORM
> -	tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> +	tristate "Intel PCH/PCU SPI flash platform driver"
>  	depends on X86 && PCI
removed " && PCI"
>  	select SPI_INTEL_SPI
>  	select LPC_ICH
removed "select LPC_ICH"
>