linux-kernel - Re: [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171024073918.GB31772@krava>
Date:   Tue, 24 Oct 2017 09:39:18 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/2] perf, tools, record: Fix -c/-F options for cpu event
 aliases

On Fri, Oct 20, 2017 at 01:27:55PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@...ux.intel.com>
> 
> The Intel PMU event aliases have a implicit
> period= specifier to set the default period.
> 
> Unfortunately this breaks overriding these periods with -c or
> -F, because the alias terms look like they are user specified
> to the internal parser, and user specified event qualifiers override
> the command line options.
> 
> Track that they are coming from aliases by adding a
> "weak" state to the term. Any weak terms don't override
> command line options.
> 
> I only did it for -c/-F for now, I think that's the
> only case that's broken currently.
> 
> Before:
> 
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
>   { sample_period, sample_freq }   2000003
> 
> After:
> 
> $ perf record -c 1000 -vv -e uops_issued.any
> ...
>   { sample_period, sample_freq }   1000
> 
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka