linux-kernel - Re: [PATCH] Clockevents: Always call clockevents_program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1710241034350.2369@nanos>
Date:   Tue, 24 Oct 2017 10:37:21 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Prasad Sodagudi <psodagud@...eaurora.org>
cc:     mingo@...nel.org, viresh.kumar@...aro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Clockevents: Always call clockevents_program_event

On Tue, 24 Oct 2017, Prasad Sodagudi wrote:

> Currently tick_program_event function is not calling
> clockevents_program_event when  'expires == KTIME_MAX',
> it is just updating clockevent state to CLOCK_EVT_STATE_ONESHOT_STOPPED.
> clockevents_program_event function updates clockevent
> device next_event by checking clockevent device state,
> so always call clockevents_program_event() from tick_program_event.

No. This is fundmentally wrong. If the clockevent is in oneshot stopped
mode then you cannot call clockevents_program_event(). There is even a
warning in that code which will trigger.

Thanks,

	tglx