linux-kernel - Re: [PATCH review for 4.9 31/50] xen/manage: correct return value check on xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Oct 2017 01:39:09 +0000
From:   "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jan Beulich <JBeulich@...e.com>
Subject: Re: [PATCH review for 4.9 31/50] xen/manage: correct return value
 check on xenbus_scanf()

On Tue, Oct 10, 2017 at 08:49:13AM -0400, Boris Ostrovsky wrote:
>On 10/07/2017 06:36 PM, Levin, Alexander (Sasha Levin) wrote:
>> From: Jan Beulich <JBeulich@...e.com>
>>
>> [ Upstream commit 4fed1b125eb6252bde478665fc05d4819f774fa8 ]
>>
>> A negative return value indicates an error; in fact the function at
>> present won't ever return zero.
>>
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>> Reviewed-by: Juergen Gross <jgross@...e.com>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>> Signed-off-by: Sasha Levin <alexander.levin@...izon.com>
>
>This patch will cause a warning to be printed. Please pull commit
>4e93b64 ("xen: don't print error message in case of missing Xenstore
>entry") as well.

Added, thanks Boris.

-- 

Thanks,
Sasha