linux-kernel - Re: [PATCH v2] net: smc_close: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171024.183014.399601216375547757.davem@davemloft.net>
Date:   Tue, 24 Oct 2017 18:30:14 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     garsilva@...eddedor.com
Cc:     ubraun@...ux.vnet.ibm.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: smc_close: mark expected switch fall-through

From: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Date: Sat, 21 Oct 2017 20:35:30 -0500

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that in this particular case I placed the "fall through" comment
> on its own line, which is what GCC is expecting to find.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
> Changes in v2:
>  Move the "fall through" comment on its own line
>  above the rest of the sentence.

Applied.