linux-kernel - Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171024021636.GZ21978@ZenIV.linux.org.uk>
Date:   Tue, 24 Oct 2017 03:16:36 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Greg Edwards <gedwards@....com>
Cc:     linux-fsdevel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

On Mon, Oct 23, 2017 at 07:10:07PM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
> 
> [   60.268688] attempt to access beyond end of device
> [   60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [   60.268693] buffer_io_error: 2 callbacks suppressed
> [   60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
> 
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <gedwards@....com>

That smells like a nasty source of overhead, especially on SMP boxen...