lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Oct 2017 15:06:51 +0200 From: Frederic Weisbecker <frederic@...nel.org> To: Ingo Molnar <mingo@...nel.org> Cc: LKML <linux-kernel@...r.kernel.org>, Frederic Weisbecker <frederic@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Chris Metcalf <cmetcalf@...lanox.com>, Thomas Gleixner <tglx@...utronix.de>, Luiz Capitulino <lcapitulino@...hat.com>, Christoph Lameter <cl@...ux.com>, "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>, Mike Galbraith <efault@....de>, Rik van Riel <riel@...hat.com>, Wanpeng Li <kernellwp@...il.com> Subject: [PATCH 02/12] watchdog: Use housekeeping_cpumask() instead of ad-hoc version While trying to disable the watchog on nohz_full CPUs, the watchdog implements an ad-hoc version of housekeeping_cpumask(). Lets replace those re-invented lines. Signed-off-by: Frederic Weisbecker <frederic@...nel.org> Cc: Chris Metcalf <cmetcalf@...lanox.com> Cc: Rik van Riel <riel@...hat.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: Mike Galbraith <efault@....de> Cc: Ingo Molnar <mingo@...nel.org> Cc: Christoph Lameter <cl@...ux.com> Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> Cc: Wanpeng Li <kernellwp@...il.com> Cc: Luiz Capitulino <lcapitulino@...hat.com> --- kernel/watchdog.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index d71eee0..3ddce04 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -774,15 +774,10 @@ int proc_watchdog_cpumask(struct ctl_table *table, int write, void __init lockup_detector_init(void) { -#ifdef CONFIG_NO_HZ_FULL - if (tick_nohz_full_enabled()) { + if (tick_nohz_full_enabled()) pr_info("Disabling watchdog on nohz_full cores by default\n"); - cpumask_copy(&watchdog_cpumask, housekeeping_mask); - } else - cpumask_copy(&watchdog_cpumask, cpu_possible_mask); -#else - cpumask_copy(&watchdog_cpumask, cpu_possible_mask); -#endif + + cpumask_copy(&watchdog_cpumask, housekeeping_cpumask()); if (!watchdog_nmi_probe()) nmi_watchdog_available = true; -- 2.7.4
Powered by blists - more mailing lists