linux-kernel - Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171024152658.GA1477@psuche>
Date:   Tue, 24 Oct 2017 09:26:59 -0600
From:   Greg Edwards <gedwards@....com>
To:     Christoph Hellwig <hch@....de>
CC:     Al Viro <viro@...IV.linux.org.uk>, <linux-fsdevel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: guard_bio_eod() needs to consider partitions

On Tue, Oct 24, 2017 at 09:46:15AM +0200, Christoph Hellwig wrote:
> On Tue, Oct 24, 2017 at 03:16:36AM +0100, Al Viro wrote:
>>> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
>>> Signed-off-by: Greg Edwards <gedwards@....com>
>>
>> That smells like a nasty source of overhead, especially on SMP boxen...
>
> We could just use __disk_get_part similar to the partition remapping,
> or just pass the block_device to guard_bio_eod.

Do you have a preference?  __disk_get_part would be isolated to
guard_bio_eod.  If we pass in the block_device, it would also touch all
the mpage_bio_submit callers.