linux-kernel - Re: [PATCH] rds: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <A88A3E1A-A919-48E2-9464-210AB7DB3E67@oracle.com>
Date:   Tue, 24 Oct 2017 18:16:23 +0200
From:   Håkon Bugge <haakon.bugge@...cle.com>
To:     Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        rds-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rds: Fix uninitialized variable

Ignore this, sent the old one.

Håkon

> On 24 Oct 2017, at 18:07, Håkon Bugge <Haakon.Bugge@...cle.com> wrote:
> 
> send_flags needs to be initialized before calling
> rds_ib_set_wr_signal_state().
> 
> Signed-off-by: Håkon Bugge <haakon.bugge@...cle.com>
> ---
> net/rds/ib_send.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
> index 6ab39db..8f46755 100644
> --- a/net/rds/ib_send.c
> +++ b/net/rds/ib_send.c
> @@ -792,6 +792,7 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
> 		send->s_atomic_wr.compare_add_mask = op->op_m_fadd.nocarry_mask;
> 		send->s_atomic_wr.swap_mask = 0;
> 	}
> +	send->s_wr.send_flags = 0;
> 	nr_sig = rds_ib_set_wr_signal_state(ic, send, op->op_notify);
> 	send->s_atomic_wr.wr.num_sge = 1;
> 	send->s_atomic_wr.wr.next = NULL;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html