lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 25 Oct 2017 10:32:52 +0800
From:   "Huang\, Ying" <>
To:     Minchan Kim <>
Cc:     "Huang\, Ying" <>,
        Andrew Morton <>,
        <>, <>,
        Tim Chen <>,
        "Michal Hocko" <>, <>,
        Christian Kujau <>
Subject: Re: [PATCH -mm] mm, swap: Fix false error message in __swp_swapcount()

Minchan Kim <> writes:

> On Tue, Oct 24, 2017 at 10:47:00AM +0800, Huang, Ying wrote:
>> From: Ying Huang <>
>> __swp_swapcount() is used in __read_swap_cache_async().  Where the
>> invalid swap entry (offset > max) may be supplied during swap
>> readahead.  But __swp_swapcount() will print error message for these
>> expected invalid swap entry as below, which will make the users
>> confusing.
>>   swap_info_get: Bad swap offset entry 0200f8a7
>> So the swap entry checking code in __swp_swapcount() is changed to
>> avoid printing error message for it.  To avoid to duplicate code with
>> __swap_duplicate(), a new helper function named
>> __swap_info_get_silence() is added and invoked in both places.
> It's the problem caused by readahead, not __swap_info_get which is low-end
> primitive function. Instead, please fix high-end swapin_readahead to limit
> to last valid block as handling to avoid swap header which is special case,
> too.

Yes.  You are right, will send the new version.

Best Regards,
Huang, Ying

Powered by blists - more mailing lists