lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Oct 2017 10:46:00 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Milian Wolff <milian.wolff@...b.com>
Cc:     acme@...nel.org, jolsa@...nel.org, Linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Yao Jin <yao.jin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>, kernel-team@....com
Subject: Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline
 for hist entry

Hi Milian,

On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote:
> On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote:
> > I looked into it and found a bug handling cumulative (children)
> > entries.  For chilren entries that has no self period, the al->addr
> > (so he->ip) ends up having an doubly-mapped address.
> > 
> > It seems to be there from the beginning but only affects entries that
> > have no srclines - finding srcline itself is done using a different
> > address but it will show the invalid address if no srcline was found.
> > I think we should fix the commit c7405d85d7a3 ("perf tools: Update
> > cpumode for each cumulative entry").
> > 
> > Could you please test the following patch works for you?
> 
> Sorry for the delay, nearly forgot about this mail. The patch below does help 
> in my situation, thanks! Can you commit it please?

Sure, I'll add your Tested-by then.

Thanks,
Namhyung

Powered by blists - more mailing lists