lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 25 Oct 2017 12:06:04 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kees Cook <keescook@...omium.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>,
        David Howells <dhowells@...hat.com>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: oss: waveartist: Convert timers to use timer_setup()

On Tue, 24 Oct 2017 22:07:34 +0200,
Kees Cook wrote:
> 
> On Tue, Oct 24, 2017 at 12:25 PM, Takashi Iwai <tiwai@...e.de> wrote:
> > On Tue, 24 Oct 2017 17:35:21 +0200,
> > Kees Cook wrote:
> >>
> >> In preparation for unconditionally passing the struct timer_list pointer to
> >> all timer callbacks, switch to using the new timer_setup() and from_timer()
> >> to pass the timer pointer explicitly.
> >>
> >> Cc: Jaroslav Kysela <perex@...ex.cz>
> >> Cc: Takashi Iwai <tiwai@...e.com>
> >> Cc: David Howells <dhowells@...hat.com>
> >> Cc: alsa-devel@...a-project.org
> >> Signed-off-by: Kees Cook <keescook@...omium.org>
> >
> > I'll skip this as sound/oss/* is already disabled in recent kernels in
> > kbuild, and we're going to remove the whole code soon later.
> 
> At the end of these conversions, the old init_timer() and
> setup_timer() APIs will be removed, which would break anything still
> trying to use it (obviously). But if sound/oss/* is _already_
> unbuildable, then sure, this is fine by me to leave out. :)

I see a few still remaining users of setup_timer() in sound/*.
Do you already have conversion patches?  They are all trivial, so I
can cook up in minutes, too.


thanks,

Takashi

Powered by blists - more mailing lists