linux-kernel - Re: [PATCH] watchdog: cpwd: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55609d72-62c0-b76f-7117-055ae1db594f@roeck-us.net>
Date:   Wed, 25 Oct 2017 03:38:45 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Kees Cook <keescook@...omium.org>
Cc:     Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: cpwd: Convert timers to use timer_setup()

On 10/25/2017 03:32 AM, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly. Switches to using the global that is
> used everywhere else.
> 
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: linux-watchdog@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/cpwd.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
> index 3d43775548e5..aee0b25cf10d 100644
> --- a/drivers/watchdog/cpwd.c
> +++ b/drivers/watchdog/cpwd.c
> @@ -230,9 +230,9 @@ static void cpwd_resetbrokentimer(struct cpwd *p, int index)
>    * interrupts within the PLD so me must continually
>    * reset the timers ad infinitum.
>    */
> -static void cpwd_brokentimer(unsigned long data)
> +static void cpwd_brokentimer(struct timer_list *unused)
>   {
> -	struct cpwd *p = (struct cpwd *) data;
> +	struct cpwd *p = cpwd_device;
>   	int id, tripped = 0;
>   
>   	/* kill a running timer instance, in case we
> @@ -275,7 +275,7 @@ static void cpwd_stoptimer(struct cpwd *p, int index)
>   
>   		if (p->broken) {
>   			p->devs[index].runstatus |= WD_STAT_BSTOP;
> -			cpwd_brokentimer((unsigned long) p);
> +			cpwd_brokentimer(NULL);
>   		}
>   	}
>   }
> @@ -608,7 +608,7 @@ static int cpwd_probe(struct platform_device *op)
>   	}
>   
>   	if (p->broken) {
> -		setup_timer(&cpwd_timer, cpwd_brokentimer, (unsigned long)p);
> +		timer_setup(&cpwd_timer, cpwd_brokentimer, 0);
>   		cpwd_timer.expires	= WD_BTIMEOUT;
>   
>   		pr_info("PLD defect workaround enabled for model %s\n",
>