linux-kernel - Re: [PATCH] drm/i915/selftests: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKkmbXQTRKrAc9q6BEKQj-O3JxF3K23ds=xsmd9dDnY7A@mail.gmail.com>
Date:   Wed, 25 Oct 2017 16:05:13 +0200
From:   Kees Cook <keescook@...omium.org>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        David Airlie <airlied@...ux.ie>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        intel-gfx@...ts.freedesktop.org,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson <chris@...is-wilson.co.uk> wrote:
> Quoting Chris Wilson (2017-10-25 11:24:19)
>> Quoting Chris Wilson (2017-10-24 17:17:09)
>> > Quoting Kees Cook (2017-10-24 16:13:44)
>> > > In preparation for unconditionally passing the struct timer_list pointer to
>> > > all timer callbacks, switch to using the new timer_setup() and from_timer()
>> > > to pass the timer pointer explicitly.
>> > >
>> > > Cc: Jani Nikula <jani.nikula@...ux.intel.com>
>> > > Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
>> > > Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
>> > > Cc: David Airlie <airlied@...ux.ie>
>> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
>> > > Cc: Chris Wilson <chris@...is-wilson.co.uk>
>> > > Cc: intel-gfx@...ts.freedesktop.org
>> > > Cc: dri-devel@...ts.freedesktop.org
>> > > Signed-off-by: Kees Cook <keescook@...omium.org>
>> >
>> > Thank you for saving me from having to do this myself,
>> > Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
>>
>> I've a small batch of selftests patches queued, so added this one and
>> will push to drm-intel-next-queued shortly.
>
> Oh dear, major faux pas. There is no timer_setup_on_stack yet.

Argh. Right, sorry. That's only in -next. Since this is mainly a
mechanical change, should I carry this in the timer tree, or wait
until the merge window for it to go via i915?

-Kees

-- 
Kees Cook
Pixel Security