linux-kernel - Re: [PATCHv2 9/9] perf tools: Unwind properly location after REJECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171025140731.GB30082@krava>
Date:   Wed, 25 Oct 2017 16:07:31 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andi Kleen <andi@...stfloor.org>,
        "Jin, Yao" <yao.jin@...ux.intel.com>,
        "Wangnan (F)" <wangnan0@...wei.com>,
        "Du, Changbin" <changbin.du@...el.com>
Subject: Re: [PATCHv2 9/9] perf tools: Unwind properly location after REJECT

On Tue, Oct 24, 2017 at 02:51:21PM +0200, Jiri Olsa wrote:
> On Fri, Oct 13, 2017 at 04:50:36PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Oct 13, 2017 at 10:37:36AM +0200, Jiri Olsa escreveu:
> > > We have defined YY_USER_ACTION to keep trace of the column
> > > location during events parsing, but we need to clean it up
> > > when we call REJECT.
> > > 
> > > When REJECT is called, the lexer shrinks the text and re-runs
> > > the matching, so we need to address it in resuming the previous
> > > location value.
> > 
> > What is this fixing? Please state that, below I show what it is breaking
> > :-/
> > 
> > Before:
> > 
> > [root@...et ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
> > bpf: builtin compilation failed: -95, try external compiler
> >      0.000 perf_bpf_probe:func:(ffffffffbb2634e0))
> >                                        sys_read ([kernel.kallsyms])
> >                                        entry_SYSCALL_64_fastpath ([kernel.kallsyms])
> >                                        __read (/usr/lib64/ld-2.25.so)
> >                                        _dl_map_object (/usr/lib64/ld-2.25.so)
> > 
> > After:
> > 
> > [root@...et ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
> > event syntax error: '/home/acme/bpf/sys_read.c/max-stack=5/'
> >                      \___ parser error
> > Run 'perf list' for a list of valid events
> > 
> >  Usage: perf trace [<options>] [<command>]
> >     or: perf trace [<options>] -- <command> [<options>]
> >     or: perf trace record [<options>] [<command>]
> >     or: perf trace record [<options>] -- <command> [<options>]
> > 
> >     -e, --event <event>   event/syscall selector. use 'perf list' to list available events
> > [root@...et ~]# 
> > 
> 
> v2 with updated changelog attached,
> 
> also I rebased the rest of the fixes and pushed
> them into perf/fixes branch

and I just rebased/pushed that once again.. we are too fast ;-)

thanks,
jirka