linux-kernel - Re: [PATCH v2 1/7] fsnotify: clean up fsnotify_prepare/finish_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOssrKd9hN+uezOrFZzchYKkW22ThZ+dA5dbG5_=_K=tH2LqQw@mail.gmail.com>
Date:   Wed, 25 Oct 2017 16:15:21 +0200
From:   Miklos Szeredi <mszeredi@...hat.com>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Jan Kara <jack@...e.cz>, Xiong Zhou <xzhou@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/7] fsnotify: clean up fsnotify_prepare/finish_user_wait()

On Wed, Oct 25, 2017 at 2:07 PM, Amir Goldstein <amir73il@...il.com> wrote:

>>> -bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info)
>>> +/*
>>> + * Get mark reference when we found the mark via lockless traversal of object
>>> + * list. Mark can be already removed from the list by now and on its way to be
>>> + * destroyed once SRCU period ends.
>>> + */
>>> +static bool fsnotify_get_mark_safe(struct fsnotify_mark *mark)
>
> Sorry, hit send too soon...
> This helper is now more than "get mark safe"
> how about fsnotify_get_mark_wait() to pair with fsnotify_put_mark_wait()?

It's get mark and pin mark->group.  I think "safe" describes that
adequately.   Added comments to reflect that.

Also renamed fsnotify_put_mark_wait() to fsnotify_put_mark_wake(),
because that's what it does.

Thanks,
Miklos