linux-kernel - Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171025152015.s34bcrgg7a3okouv@tesla>
Date:   Wed, 25 Oct 2017 17:20:15 +0200
From:   Javi Merino <javi.merino@...nel.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     amit.kachhap@...il.com, viresh.kumar@...aro.org,
        rui.zhang@...el.com, edubezval@...il.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] thermal: cpu_cooling:  pr_err() strings should end with
 newlines

On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

FWIW,

Acked-by: Javi Merino <javi.merino@...nel.org>

> ---
>  drivers/thermal/cpu_cooling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 908a801..dc63aba 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -696,7 +696,7 @@ static unsigned int find_next_max(struct cpufreq_frequency_table *table,
>  	bool first;
>  
>  	if (IS_ERR_OR_NULL(policy)) {
> -		pr_err("%s: cpufreq policy isn't valid: %p", __func__, policy);
> +		pr_err("%s: cpufreq policy isn't valid: %p\n", __func__, policy);
>  		return ERR_PTR(-EINVAL);
>  	}
>  
> -- 
> 1.9.1
>