linux-kernel - Re: [RFC 10/14] bootsplash: Add animation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b47c2af-1ddd-a526-601e-1781bef65232@infradead.org>
Date:   Wed, 25 Oct 2017 10:20:38 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Max Staudt <mstaudt@...e.de>, b.zolnierkie@...sung.com,
        linux-fbdev@...r.kernel.org
Cc:     tiwai@...e.com, oneukum@...e.com, msrb@...e.com, sndirsch@...e.com,
        michal@...kovi.net, linux-kernel@...r.kernel.org
Subject: Re: [RFC 10/14] bootsplash: Add animation support

On 10/25/17 05:45, Max Staudt wrote:
> @@ -117,17 +128,45 @@ static bool is_fb_compatible(struct fb_info *info)
>   */
>  void bootsplash_render_full(struct fb_info *info)
>  {
> +	bool is_update = false;
> +
>  	mutex_lock(&splash_global.data_lock);
>  
> -	if (!is_fb_compatible(info))
> -		goto out;
> +	/* If we've painted on this FB recently, we don't have to do
> +	 * the sanity checks and background drawing again.
> +	 */

multi-line comment style needs to be corrected in multiple places (in
several of the patches).


-- 
~Randy